[Webkit-unassigned] [Bug 179682] Incorrect bounds inside <mover>/<munder> when a stretchy operator is present

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 8 07:15:14 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=179682

--- Comment #64 from zalan <zalan at apple.com> ---
Comment on attachment 328775
  --> https://bugs.webkit.org/attachment.cgi?id=328775
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328775&action=review

> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:53
> +static RenderMathMLOperator* toHorizontalStretchyOperator(RenderBox* box)

const RenderBox& box (unembellishedOperator should really be a const function)

> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:55
> +    if (is<RenderMathMLBlock>(box)) {

in WebKit, we tend to use early returns instead
if (!is<RenderMathMLBlock>(box))
    return nullptr;

> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:56
> +        if (auto renderOperator = downcast<RenderMathMLBlock>(*box).unembellishedOperator()) {

if (auto* renderOperator

> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:64
> +static void fixLayoutAfterStretch(RenderBox* ancestor, RenderMathMLOperator* stretchyOperator)

RenderBox& ancestor, RenderMathMLOperator& stretchyOperator

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171208/43a90299/attachment.html>


More information about the webkit-unassigned mailing list