[Webkit-unassigned] [Bug 180294] [Web App Manifest] Add SPI for fetching the manifest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 6 13:14:25 PST 2017


--- Comment #12 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 328608
  --> https://bugs.webkit.org/attachment.cgi?id=328608
Patch for landing v4

View in context: https://bugs.webkit.org/attachment.cgi?id=328608&action=review

> Tools/WebKitTestRunner/TestInvocation.cpp:1258
> +#else
> +        WKRetainPtr<WKStringRef> messageName = adoptWK(WKStringCreateWithUTF8CString("DidGetApplicationManifest"));
> +            WKPagePostMessageToInjectedBundle(TestController::singleton().mainWebView()->page(), messageName.get(), 0);
> +#endif

Nit: Weird indent on 1257.

Last comment.

This strikes me as misleading. In the non __BLOCKS__ case, this does nothing. So if another port enables APPLICATION_MANIFEST the tests may pass (if they don't dump console messages or loader delegates), but they won't actually be doing anything?

I think we may want to put a FIXME here to add an API to actually get the application manifest if !__BLOCKS__. Perhaps even a compile time error (#error), to immediately tell developers they need a provide an API to get the manifest without block.

Otherwise a port enabling this feature might not know they they need to provide an API to get things working.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171206/d8c96222/attachment.html>

More information about the webkit-unassigned mailing list