[Webkit-unassigned] [Bug 180294] [Web App Manifest] Add SPI for fetching the manifest
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 6 11:56:10 PST 2017
https://bugs.webkit.org/show_bug.cgi?id=180294
--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 328590
--> https://bugs.webkit.org/attachment.cgi?id=328590
Patch for landing v3
View in context: https://bugs.webkit.org/attachment.cgi?id=328590&action=review
Thanks for addressing the follow-up comments!
> LayoutTests/applicationmanifest/multiple-links-expected.txt:8
> +layer at (0,0) size 800x600
> + RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x600
> + RenderBlock {HTML} at (0,0) size 800x600
> + RenderBody {BODY} at (8,8) size 784x584
It is super weird to have Render Tree output on a test that doesn't need it.
You should be able to add `testRunner.dumpAsText()` to the test to avoid this unnecessary output (which you do up above with developer-warnings.html.
> LayoutTests/applicationmanifest/multiple-links.html:8
> + testRunner.notifyDone();
Nit: Weird indent.
> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm:38
> +- (instancetype)initWithCoder:(NSCoder *)aDecoder
This reads much better to me now. Thanks!
> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm:130
> +- (instancetype)initWithCoder:(NSCoder *)aDecoder
> +{
> + UNUSED_PARAM(aDecoder);
> + return nil;
> +}
I suppose technically this won't be reached, but it might need a [self release]?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171206/6f92a6af/attachment-0001.html>
More information about the webkit-unassigned
mailing list