[Webkit-unassigned] [Bug 180294] [Web App Manifest] Add SPI for fetching the manifest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180294

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org

--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 328369
  --> https://bugs.webkit.org/attachment.cgi?id=328369
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=328369&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm:40
> +- (instancetype)initWithCoder:(NSCoder *)aDecoder
> +{
> +    [self release];

I'll admit to not being totally familiar with WebKit2's API objects, but this pattern strikes me as odd.

Could you use API::Object::constructInWrapper<...>? Does the wrapped object need to be destructed in a -dealloc to avoid leaks? My suspicion is that there can be leaks as written.

See _WKFrameHandle or _WKProcessPoolConfiguration for examples of the kinds of patterns I was expected to see.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171205/507a2746/attachment.html>