[Webkit-unassigned] [Bug 180126] Add a test health page.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180126

--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to dewei_zhu from comment #5)
> Comment on attachment 327826 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327826&action=review
> 
> >>> Websites/perf.webkit.org/public/v3/components/test-health-cell.js:42
> >>> +        return `/v3/#/charts?since=${Date.now() - 7 * 24 * 3600 * 1000}&paneList=((${this._platform.id()}-${this._metric.id()}))`;
> >> 
> >> Does performance dashboard code have a centralized place where URLs are built? Doing it in every view controller seems less than ideal.
> > 
> > See PageRouter and how it's used. We should never build a URL string like this. r-.
> 
> Are you suggesting make PageRouter.url and dependent functions static
> functions and call PageRouter.url here with `charts` and {since: ...,
> paneList ...} as arguments?
> Or I dup the logic implemented in PageRouter.url?

See line 101 of dashboard-pages.js.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171205/82e7b80c/attachment.html>