[Webkit-unassigned] [Bug 180262] [Gstreamer][MSE] Add string representation for GStreamerMediaSample

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 5 00:24:46 PST 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #328177|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 328177
  --> https://bugs.webkit.org/attachment.cgi?id=328177

View in context: https://bugs.webkit.org/attachment.cgi?id=328177&action=review

Patch is not wrong, though I'd improve it.

> Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:120
> +    out.print("{PTS(", presentationTime(), "), DTS(", decodeTime(), "), duration(", duration(), "), flags(", (int)flags(),

Instead of (int), I'd use a C++ cast, though in this case I'd rather dump the flags instead of just casting them to an int.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171205/b12e8052/attachment.html>

More information about the webkit-unassigned mailing list