[Webkit-unassigned] [Bug 180294] [Web App Manifest] Add SPI for fetching the manifest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 4 15:37:39 PST 2017


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |ggaren at apple.com
 Attachment #328369|review?                     |review+
              Flags|                            |

--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 328369
  --> https://bugs.webkit.org/attachment.cgi?id=328369
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=328369&action=review

r=me with comments

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4354
> +    _page->getApplicationManifest([completion = makeBlockPtr(completionHandler)](const std::optional<WebCore::ApplicationManifest>& manifest, WebKit::CallbackBase::Error error) {

You can just call this "completionHandler" as we do elsewhere, since the lambda creates a new lexical scope.

> Source/WebKit/UIProcess/WebPageProxy.cpp:5323
> +        // FIXME: Log error or assert.
> +        // this can validly happen if a load invalidated the callback, though

This comment contradicts itself, so you should remove it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171204/44999e04/attachment-0001.html>

More information about the webkit-unassigned mailing list