[Webkit-unassigned] [Bug 179500] AX: AOM: Implement relation type properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179500

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328064|review?                     |review+
              Flags|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 328064
  --> https://bugs.webkit.org/attachment.cgi?id=328064
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328064&action=review

r=me with the assertion change.

>>> Source/WebCore/accessibility/AccessibilityObject.cpp:2194
>>> +            return elements.first();
>> 
>> What happens when elements contain more than one elements?
>> Should that ever happen? If so, is it really correct to return nullptr in that case?
>> Where is this behavior spec'ed?
> 
> I implemented this as a convenient function for relation types that only contain one AccessibleNode. Maybe we should add an assert here to make sure it only contains one element.
> The more than one elements case should be addressed in another bug. In that case we could have elementsValueForProperty(property)
> https://wicg.github.io/aom/spec/#accessiblenodelist-interface

Okay. Please add an assert to check that there is either 0 or 1 element.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171204/3f8e51de/attachment-0001.html>