[Webkit-unassigned] [Bug 180258] [MSE] Add isValid() check before using trackBuffer.lastEnqueuedPresentationTime

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 4 04:26:33 PST 2017


--- Comment #3 from Alicia Boya GarcĂ­a <aboya at igalia.com> ---
No.(In reply to Jer Noble from comment #2)
> Comment on attachment 328114 [details]
> Patch
> Is this change fix something, and if so, should it have a test?

I'm not sure, that's why I'm asking if the assumption in the `if` above was intentional.

As I see it, if is not intentional (i.e. it's possible that lastEnqueuedPresentationTime is MediaTime::invalidTime()) then we should check for that as in the patch.

If it's intentional (i.e. it can never be invalid time), it's not obvious and should have an ASSERT() to make it more evident and avoid unexpected side effects should that ever cease being the case.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171204/a244125e/attachment.html>

More information about the webkit-unassigned mailing list