[Webkit-unassigned] [Bug 180244] WebDriver: implement element property command

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180244

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #4)
> (In reply to Brian Burg from comment #3)
> > Comment on attachment 328089 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=328089&action=review
> > 
> > r=me
> > 
> > > Source/WebDriver/Session.cpp:1321
> > > +                return;
> > 
> > It's not clear to me what will happen if element.`property` is undefined.
> > Will it return an error or not? Just looking at the W3C test names, I can't
> > easily tell that this case is covered.
> 
> Good point, I think it will return a JS error, because the code will raise
> an exception, I guess. We should handle that case and return null.

I've checked this and it's tested by test_element_non_existent. We need to handle it, but in a more general way, so I'll fix this and other similar cases in a follow up patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171204/8497c075/attachment.html>