[Webkit-unassigned] [Bug 180303] New: Add docstring in EarlyWarningSystemTask to explain return values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180303

            Bug ID: 180303
           Summary: Add docstring in EarlyWarningSystemTask to explain
                    return values
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aakash_jain at apple.com
                CC: lforschler at apple.com

EarlyWarningSystemTask run() method has return value which are slightly non-intuitive. False does not indicate that patch failed EWS, it indicates that EWS is not sure. Patch failure is indicated by an exception. We should document these values in order to avoid confusion.

Having this comment could have prevented https://bugs.webkit.org/show_bug.cgi?id=180302

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171202/0db49ff9/attachment-0001.html>