[Webkit-unassigned] [Bug 180211] Move DateComponents into WTF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 1 13:00:48 PST 2017


--- Comment #5 from Christopher Reid <christopher.reid at am.sony.com> ---
(In reply to Myles C. Maxfield from comment #4)
> Comment on attachment 328062 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328062&action=review
> > Source/WTF/wtf/DateComponents.hSource/WebCore/platform/DateComponents.h:70
> > +    WTF_EXPORT_PRIVATE int millisecond() const { return m_millisecond; }
> Aren't these inlined? What is the EXPORT for?

I thought I remembered seeing linker errors with those inlined functions, but I tried it again and it looks like I was just overzealous with what I was exporting. I'll take those out.


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171201/0d6f5eba/attachment.html>

More information about the webkit-unassigned mailing list