[Webkit-unassigned] [Bug 180258] New: [MSE] Add isValid() check before using trackBuffer.lastEnqueuedPresentationTime

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180258

            Bug ID: 180258
           Summary: [MSE] Add isValid() check before using
                    trackBuffer.lastEnqueuedPresentationTime
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media Elements
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aboya at igalia.com

The current comparison in sourceBufferPrivateDidReceiveSample() does not take in account the possibility of lastEnqueuedPresentationTime not being set.

MediaTime currentMediaTime = m_source->currentTime();
if (currentMediaTime < trackBuffer.lastEnqueuedPresentationTime) {
    PlatformTimeRanges possiblyEnqueuedRanges(currentMediaTime, trackBuffer.lastEnqueuedPresentationTime);
    possiblyEnqueuedRanges.intersectWith(erasedRanges);
    if (possiblyEnqueuedRanges.length())
        trackBuffer.needsReenqueueing = true;
}

Is this intentional? When experimenting with a new frame removal algorithm I hit a case where it was unset and therefore it created an invalid range in possiblyEnqueuedRanges.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171201/902963f1/attachment.html>