[Webkit-unassigned] [Bug 176069] [WinCairo] Add Network Process files for wincairo webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 31 04:09:11 PDT 2017


Yousuke Kimoto <Yousuke.Kimoto at sony.com> changed:

           What    |Removed                     |Added
                 CC|                            |Yousuke.Kimoto at sony.com

--- Comment #3 from Yousuke Kimoto <Yousuke.Kimoto at sony.com> ---
(In reply to Alex Christensen from comment #2)
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319424&action=review
> > Source/WebKit/ChangeLog:8
> > +        * NetworkProcess/CustomProtocols/curl/LegacyCustomProtocolManagerCurl.cpp: Added.
> Let's not add an attempt to implement LegacyCustomProtocolManager. 
> Implement API::URLSchemeTask instead.

Thank you for your review. I'm working for this patch with Stephan Szabo.

Why should not an attempt implementation be added to LegacyCustomProtocolManager? If it is not implemented, many LINK errors occur.
For example,  DerivedSources/WebKit2/LegacyCustomProtocolManagerMessageReceiver.cpp requires them.
Those implementations are just to solve such LINK errors.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170831/bcce4aad/attachment.html>

More information about the webkit-unassigned mailing list