[Webkit-unassigned] [Bug 175926] Speedometer: Remove unused stylesheet in Ember example

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175926

--- Comment #6 from Mathias Bynens <mathias at qiwi.be> ---
(In reply to Ryosuke Niwa from comment #4)
> Comment on attachment 318972 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318972&action=review
> 
> > PerformanceTests/ChangeLog:10
> > +        * Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/index.html: Removed stylesheet reference.
> > +        * Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/styles/.gitkeep: Added.
> > +        * Speedometer/resources/todomvc/architecture-examples/emberjs/source/dist/*: Regenerated per build instructions.
> 
> Something is not right. tests.js refer to
> todomvc/architecture-examples/emberjs/index.html yet this is re-generating
> emberjs/source/dist/index.html:
> 
> Suites.push({
>     name: 'EmberJS-TodoMVC',
>     url: 'todomvc/architecture-examples/emberjs/index.html',

Good catch. That should’ve been `todomvc/architecture-examples/emberjs/source/dist/index.html` all along.

EmberJS is the only test with such a weird directory structure: `/emberjs` is pretty much empty, `/emberjs/source` contains the actual source, but the output is written to `/emberjs/source/dist`. The new patch fixes that as well by getting rid of the intermediate `source` folder.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170824/21bbc578/attachment.html>