[Webkit-unassigned] [Bug 175728] Web Inspector: Create experimental Layers tab

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 23 14:06:57 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=175728

--- Comment #14 from Ross Kirsling <ross.kirsling at sony.com> ---
(In reply to Matt Baker from comment #12)
> > Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:118
> > +                    this._addLayer(childLayers[i], i);
> 
> Since this is the only place Layers3DContentView.prototype._addLayer is
> called, and layer meshes are always added in order, the index can be omitted
> and the loop rewritten as a for...of.

I'd love to, but I need the index for the Z coordinate. :P

> > Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:128
> > +        this._camera.aspect = this.element.offsetWidth / this.element.offsetHeight;
> 
> Check for DBZ.

(Just noting that we discussed this on IRC.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170823/c03c1eaa/attachment-0001.html>


More information about the webkit-unassigned mailing list