[Webkit-unassigned] [Bug 175728] Web Inspector: Create experimental Layers tab
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 23 13:20:44 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=175728
--- Comment #12 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 318907
--> https://bugs.webkit.org/attachment.cgi?id=318907
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=318907&action=review
> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:110
> + layout() {
Style: open brace should be on it's own line.
> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:118
> + this._addLayer(childLayers[i], i);
Since this is the only place Layers3DContentView.prototype._addLayer is called, and layer meshes are always added in order, the index can be omitted and the loop rewritten as a for...of.
> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:128
> + this._camera.aspect = this.element.offsetWidth / this.element.offsetHeight;
Check for DBZ.
> Source/WebInspectorUI/UserInterface/Views/LayersTabContentView.js:58
> + get type()
Style: simple getters that return a constant of member variable can be a single line.
> Source/WebInspectorUI/UserInterface/Views/LayersTabContentView.js:63
> + get supportsSplitContentBrowser()
Ditto.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170823/fb7550fb/attachment.html>
More information about the webkit-unassigned
mailing list