[Webkit-unassigned] [Bug 129879] Geoclue2 based backend should provide the right desktop ID

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 23 07:47:03 PDT 2017


Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |aperez at igalia.com

--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
(In reply to Michael Catanzaro from comment #4)
> (In reply to Carlos Alberto Lopez Perez from comment #2)
> > I wonder if its even possible to provide the right desktop ID on all cases?
> No it's not possible, not unless we add new API. That's not needed, because
> it's easier to just require that g_get_prgname() match the desktop ID. I
> think we should change nothing and just document this somewhere.

There is a much better way than using g_get_prgname() — GApplication

   const char* appid = nullptr;
   GApplication* app = g_application_get_default();
   if (app) {
     appid = g_application_get_application_id(app);
   // Maybe add a fall-back to g_get_prgname()

This allows different values for the application identifier, and the program
name. It is very common that they are different. Example: the program name
for Epiphany is “epiphany” (the name of the binary on disk), and the application
identifier is “org.gnome.Epiphany”.

We should use GApplcation when GLib 2.32+ is available, and document that
setting an application identifier using GApplication/GtkApplication is
needed for geolocation to work.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170823/9fb1f9d5/attachment-0001.html>

More information about the webkit-unassigned mailing list