[Webkit-unassigned] [Bug 175715] Speedometer: Update to modern React version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 23 00:02:40 PDT 2017


--- Comment #18 from Mathias Bynens <mathias at qiwi.be> ---
Comment on attachment 318748
  --> https://bugs.webkit.org/attachment.cgi?id=318748

View in context: https://bugs.webkit.org/attachment.cgi?id=318748&action=review

>> PerformanceTests/ChangeLog:8
>> +        This updates React and react-dom to v15.5.4 (released in May 2017).
> Looks like this patch doesn't update anything in the benchmark? It's simply removing a bunch of files and only updating package.json?

Ah, yes that’s correct. v15.5.4 turns out to be the version Speedometer currently uses. This patch makes that explicit by pinning that version in `package.json`, documents the build steps, and gets rid of some unneeded files.

> PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react/index.html:17
> +        <script src="node_modules/director/build/director.min.js"></script>

Directories named `build` seem to be ignored in this repository. Can we relax that restriction so that we can commit this file (without having to move it around)?

Alternatively, we could add `mv node_modules/director/{build/,}director.min.js` to the build script (although that feels a bit hacky).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170823/75456441/attachment.html>

More information about the webkit-unassigned mailing list