[Webkit-unassigned] [Bug 175728] Web Inspector: Create experimental Layers tab

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175728

--- Comment #8 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 318641
  --> https://bugs.webkit.org/attachment.cgi?id=318641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318641&action=review

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:34
> +        WI.layerTreeManager.addEventListener(WI.LayerTreeManager.Event.LayerTreeDidChange, this._layerTreeDidChange, this);

This listener needs to be removed when the ContentView is closed().

Additionally, this event is going to be firing whenever the view is not visible.  It might be better to move the add/remove of this event listener to shown()/hidden().  As far as I understand, layout() should be called when shown() gets called, so you're already going to redraw anyways.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:36
> +        this._layersChangedWhileHidden = false;

Along the lines of the previous comment, moving the event listener to shown()/hidden() will remove the need for this variable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170823/aad6cdca/attachment.html>