[Webkit-unassigned] [Bug 175763] Speedometer: Update to modern Preact version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 22 13:55:23 PDT 2017


--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Mathias Bynens from comment #6)
> (In reply to Ryosuke Niwa from comment #5)
> > (In reply to Mathias Bynens from comment #2)
> > > Side note: can we make the style checker ignore `dist` directories under
> > > `PerformanceTests/Speedometer`? Currently, I end up having to replace tabs
> > > with spaces in the *generated* files before submitting these patches, just
> > > to appease the style checks.
> > 
> > We could but then commits would fail since we have a pre-commit hook to
> > prevent tab characters from being committed into the repository.
> I’m guessing the pre-commit hook cannot easily be changed accordingly? :)

You can bypass it if you're a committer but I don't think it's worth the effort. Really, we don't want tab characters in our repository unless absolutely required.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170822/0d40a688/attachment.html>

More information about the webkit-unassigned mailing list