[Webkit-unassigned] [Bug 175815] REGRESSION(r216718): Speedometer 2.0: Fix vanilla JS examples

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175815

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REGRESSION(R220043):        |REGRESSION(r216718):
                   |Speedometer 2.0: Fix        |Speedometer 2.0: Fix
                   |vanilla JS examples         |vanilla JS examples

--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Mathias Bynens from comment #3)
> Comment on attachment 318744 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318744&action=review
> 
> > PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:5
> > +var uniqueID = 0;
> 
> `vanilla-examples/es2015/src/store.js` has the same line but uses `let`
> instead of `var` and starts at `1` instead of `0`. Is there a reason for
> these subtle differences? If so, we may want to add a comment saying so.

It looked like all variable declarations in this file was using `var` so I used that to be consistent.

(In reply to Mathias Bynens from comment #4)
> How did https://trac.webkit.org/changeset/220043/webkit(In reply to Ryosuke
> Niwa from comment #0)
> > Vanilla JS & ES2015 test cases got broken again in
> > https://trac.webkit.org/changeset/217107
> 
> That doesn’t seem like the right link.
> 
> This bug’s title refers to R220043 but that patch didn’t touch any
> JavaScript: https://trac.webkit.org/changeset/220043
> 
> Did you mean R216718 instead? https://trac.webkit.org/changeset/216718

Oops, fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170822/8a096958/attachment.html>