[Webkit-unassigned] [Bug 175818] Speedometer: Make React/Redux item order consistent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 22 13:51:06 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=175818

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 318749
  --> https://bugs.webkit.org/attachment.cgi?id=318749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318749&action=review

Don't you need to rebuild? We're loading bundle files in the actual test?

> PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.js:14
> +        ...state,
>          {
>            id: state.reduce((maxId, todo) => Math.max(todo.id, maxId), -1) + 1,
>            completed: false,
>            text: action.text
> -        },
> -        ...state
> +        }

Hm... I swear I tried this and didn't work :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170822/a87afb30/attachment-0001.html>


More information about the webkit-unassigned mailing list