[Webkit-unassigned] [Bug 175715] Speedometer: Update to modern React version

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175715

--- Comment #13 from Mathias Bynens <mathias at qiwi.be> ---
The issue is this: https://github.com/facebook/react/commit/045f1a791c6e17253e9d927ffca70ae5d00b4fe5 (which was later cherry-picked and backported to React v15) intentionally prevented React’s `onChange` from triggering after programmatic value changes.

As a result, our `handleChange` never gets called when using the runner, so the new TODO item’s internal value never gets updated through the `setState` call. It’s stuck at the default value, i.e. the empty string.

Therefore, when Enter is programmatically pressed and `handleNewTodoKeyDown` is called, the `if (val)` check fails, and the TODO item never gets added to the list.

I’ve asked if there’s a reasonable way to work around this behavior without patching our React copy: https://github.com/facebook/react/pull/5746#issuecomment-323947947

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170822/bad7797e/attachment.html>