[Webkit-unassigned] [Bug 175738] Make GetDynamicVar propagate heap predictions instead of saying HeapTop

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 21 02:48:18 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=175738

--- Comment #6 from Robin Morisset <rmorisset at apple.com> ---
On the micro-benchmark I added, there is an improvement, but it is small: time to execute in release mode goes from 245ms to 235ms on my machine. Should I try to make a larger benchmark that makes the difference more visible, or was this level of improvement what was expected?

Node::identifierNumber() just works, since it reads the OpInfoWrapper union as an int32, so it should only load the low bits.

The bug on compilation on the build bots seemed to be caused by the function makeDynamicVarOpInfo not having its prototype declared separately. I don't see why that is a problem, so I just added the prototype next to the declaration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170821/35c82875/attachment.html>


More information about the webkit-unassigned mailing list