[Webkit-unassigned] [Bug 175728] Web Inspector: Create experimental Layers tab

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175728

Devin Rousso <webkit at devinrousso.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit at devinrousso.com

--- Comment #6 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 318552
  --> https://bugs.webkit.org/attachment.cgi?id=318552
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318552&action=review

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:54
> +            this._layersChangedWhileHidden = false;
> +            this.updateLayout();

Style: add newline.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:57
> +        if (this._didInitialLayout)

There is a protected getter for this.  Use that instead.

    if (this.didInitialLayout)

> Source/WebInspectorUI/UserInterface/Views/LayersTabContentView.js:33
> +        super("layers", "layers", tabBarItem, null, null, true);

For the `null` and `true` values, we like to use const variables to help explain what those values mean.

    const navigationSidebarPanelConstructor = null;
    const detailsSidebarPanelConstructors = null;
    const disableBackForward = true;
    super("layers", "layers", tabBarItem, navigationSidebarPanelConstructor, detailsSidebarPanelConstructors, disableBackForward);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170820/7dff3069/attachment.html>