[Webkit-unassigned] [Bug 175738] Make GetDynamicVar propagate heap predictions instead of saying HeapTop

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 18 16:33:18 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=175738

--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318553
  --> https://bugs.webkit.org/attachment.cgi?id=318553
Patch, not yet benchmarked

View in context: https://bugs.webkit.org/attachment.cgi?id=318553&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4071
> +    ASSERT(sizeof(identifierNumber) == 4);

let's use static assert

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4072
> +    return identifierNumber | ((uint64_t) getPutInfo << 32);

style nit: we use static_cast in webkit instead of c-style casts

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170818/249bd797/attachment.html>


More information about the webkit-unassigned mailing list