[Webkit-unassigned] [Bug 174615] WebDriver: implement screen capture commands

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 18 12:19:42 PDT 2017


Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
 Attachment #318355|review?                     |review+
              Flags|                            |

--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 318355
  --> https://bugs.webkit.org/attachment.cgi?id=318355

View in context: https://bugs.webkit.org/attachment.cgi?id=318355&action=review


Please re-run through EWS.

> Source/WebKit/ChangeLog:16
> +        checkjed and passed to the web process.

Nit: checked

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:691
>      RefPtr<WebImage> image = page->scaledSnapshotWithOptions(snapshotRect, 1, SnapshotOptionsShareable);

We received a bug the other day that the scale factor should be inherited from the device. Right now, retina screenshots are at @1x and look blurry. But that's a separate bug.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170818/09788bae/attachment.html>

More information about the webkit-unassigned mailing list