[Webkit-unassigned] [Bug 175719] [GTK][WPE] ASSERTION FAILED: !isOpen() in WebKit::IconDatabase::~IconDatabase()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175719

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318492|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 318492
  --> https://bugs.webkit.org/attachment.cgi?id=318492
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318492&action=review

Nice!

> Source/WebKit/UIProcess/API/glib/IconDatabase.h:196
> +            if (!m_timer.isActive())

I would add a blank line here.

> Source/WebKit/UIProcess/API/glib/IconDatabase.h:229
> +        RunLoop::Timer<MainThreadNotifier> m_timer;

You're certain m_timer does not need to be guarded by a lock? Why not?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170818/fb1c6a82/attachment.html>