[Webkit-unassigned] [Bug 175667] [WPE][GTK] Ensure proper casting of data in gvariants

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 17 08:35:07 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #318369|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 318369
  --> https://bugs.webkit.org/attachment.cgi?id=318369

View in context: https://bugs.webkit.org/attachment.cgi?id=318369&action=review

Nice, thanks. Real shame we don't have static analysis to catch this sort of problem.

> Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp:174
> -    g_variant_builder_add(sessionBuilder, "d", frameState.pageScaleFactor);
> +    g_variant_builder_add(sessionBuilder, "d", static_cast<gdouble>(frameState.pageScaleFactor));

I'm a bit concerned because this affected serialized session state, but not much we can do about that.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170817/ff97f5c9/attachment.html>

More information about the webkit-unassigned mailing list