[Webkit-unassigned] [Bug 175584] We are too conservative about the effects of PushWithScope

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175584

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318210|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318210
  --> https://bugs.webkit.org/attachment.cgi?id=318210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318210&action=review

> Source/JavaScriptCore/dfg/DFGClobberize.h:475
> +        read(ScopeProperties);

This is not the case, this node does not read ScopeProperties. This heap kind is for GetClosureVar, PutClosureVar.

Also, please add tests that stress the CSE this opens up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170816/40b7389d/attachment-0001.html>