[Webkit-unassigned] [Bug 174036] [XCode] webkit-patch should run sort-Xcode-project-file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 15 13:24:38 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174036

--- Comment #20 from Andy Estes <aestes at apple.com> ---
(In reply to Matthew Hanson from comment #16)
> Perhaps we could server-side commit hook in combination with a tool that
> sorts the project files. That would require an initial sorting of all
> project files, but would allow us to guarantee the sorted-ness of project
> files going forward.
> 
> The commit hook rejection message could include the location of the tool
> that will sort project files.

I actually like this idea even more than a style checker change. With the style checker, I'd still end up ignoring it if it complains about unrelated sorting issues. With a commit hook guaranteeing that projects in the repository are always sorted, I'll know that any issue is due to my patch and not some unrelated change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170815/6c806791/attachment-0001.html>


More information about the webkit-unassigned mailing list