[Webkit-unassigned] [Bug 174036] [XCode] webkit-patch should run sort-Xcode-project-file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 15 12:16:53 PDT 2017


--- Comment #18 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Andy Estes from comment #17)
> (In reply to Ryosuke Niwa from comment #14)
> > Yeah, adding checks to the style checker will prevent this regardless of
> > whether you're using webkit-patch or not.
> I'd be fine with that.
> > 
> > In general, people shouldn't be adding out-of-order files in the first place.
> I agree, but you can add a file to the Xcode UI in correct sorted order and
> still have sections of the .pbxproj file that aren't sorted correctly.

In many instances, that ends up in the file shown in a wrong order somewhere else in UI so I'd argue that we should just always sort them in the right order for the sake of simplicity. Figuring out which entry does and doesn't affect UI is way too much work given the inhumane format of xcodeproj files.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170815/c9c85edc/attachment-0001.html>

More information about the webkit-unassigned mailing list