[Webkit-unassigned] [Bug 174036] [XCode] webkit-patch should run sort-Xcode-project-file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174036

--- Comment #12 from Andy Estes <aestes at apple.com> ---
(In reply to Andy Estes from comment #10)> 
> I'd be fine with having an option to run sort-Xcode-project-file, but I
> object to this being done by default.

Reasons for my objection:

1. It makes patches harder to review when they have unrelated Xcode project file changes in them.
2. It makes patches harder to merge to branches (I've already experienced one merge conflict due to this feature).
3. Engineers tend to keep items in sorted order in the UI, which means that sort-Xcode-project-file is often just rearranging lists that aren't visible to the user. Having my patch include unrelated sorting changes to non-user-visible lists in .pbxproj files seems pretty low-value to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170815/5ca04fa7/attachment.html>