[Webkit-unassigned] [Bug 175571] New: MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175571

            Bug ID: 175571
           Summary: MemoryCache::setCapacities assertion failure
                    maxDeadBytes <= totalBytes
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cturner at igalia.com

After the grand move from WebKit2 -> WebKit, I was struggling to find information about these caching policies and what exactly they mean. The problem is that calculateMemoryCacheSizes fails to set cacheTotalCapacity to something sensible if the system has less than 512MB of RAM. This,

        // This code is here to avoid a PLT regression. We can remove it if we
        // can prove that the overall system gain would justify the regression.
        cacheMaxDeadCapacity = std::max(24u, cacheMaxDeadCapacity);

Then obviously violates the checks in MemoryCache::setCapacities, because at this point cacheTotalCapacity is zero from the callsite.

Patch basically follows the pattern to make sure cacheTotalCapacity is set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170815/092dd4a2/attachment.html>