[Webkit-unassigned] [Bug 175315] WebDriver: timeout when JavaScript alert is shown in onload handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175315

--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 318038
  --> https://bugs.webkit.org/attachment.cgi?id=318038
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318038&action=review

>> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:512
>> +            callback->sendSuccess(InspectorObject::create());
> 
> Will this return "data null" in the driver endpoint per step 8?

Right

>> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:532
>> +        if (!page->isValid() || !page->pageLoadState().isLoading() || !m_client->isShowingJavaScriptDialogOnPage(*this, page))
> 
> What if the session was destroyed? Do we need a guard for that and a protectRef for |this|?

Yes, this is already protected in the lambda, but we need to null check the client.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170815/3a853b23/attachment.html>