[Webkit-unassigned] [Bug 174710] WebDriver: handle click events on option elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 14 10:20:35 PDT 2017


Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
 Attachment #318034|review?                     |review+
              Flags|                            |

--- Comment #13 from Brian Burg <bburg at apple.com> ---
Comment on attachment 318034
  --> https://bugs.webkit.org/attachment.cgi?id=318034
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318034&action=review

enthusiastic r=me!

> Source/WebKit/UIProcess/Automation/Automation.json:437
> +                { "name": "browsingContextHandle", "$ref": "BrowsingContextHandle", "description": "The handle for the browsing context." },

Nit: you can just omit these comments if they don't add much.

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:509
> +static WebCore::Element* elementContainer(WebCore::Element& element)

Nit: maybe containerElementForElement() to make it read better...

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:559
> +    auto* containerElement = elementContainer(*coreElement);

... down here.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170814/22c794ff/attachment-0001.html>

More information about the webkit-unassigned mailing list