[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

--- Comment #20 from Frederik Riedel <riedel at apple.com> ---
Comment on attachment 316993
  --> https://bugs.webkit.org/attachment.cgi?id=316993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316993&action=review

> Source/WebCore/html/HTMLInputElement.cpp:909
> +        usernameElement->setValue(username);

We should use setValueForUser(username) instead. This simulates user input instead of just setting the value.

> Source/WebCore/html/HTMLInputElement.cpp:911
> +        passwordElement->setValue(password);

Ditto for setValueForUser(password).

>> Source/WebCore/html/HTMLInputElement.cpp:927
>> +            Element* previousElement = document().previousFocusableElement(*start);
> 
> I don't think we should assume that the username and password text fields are next to each other after start element.
> Safari should just figure out which element is for username & which one is for password and call [inputElement setValue] instead.

Isn't the previousFocusableElement/nextFocusableElement the same API that we use for the little blue arrow keys on top of iOS's keyboard? In this case I would expect that it works for most login forms (simulate pressing "tab").

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170811/4fd7a9ac/attachment-0001.html>