[Webkit-unassigned] [Bug 175470] Support the with keyword in DFG

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175470

--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 317933
  --> https://bugs.webkit.org/attachment.cgi?id=317933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317933&action=review

LGTM.
It would be nice to add some tests that specifically target DFG compilation.
Does it pass other JSC tests?

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2069
> +        forNode(node).setType(m_graph, SpecObjectOther);

We could do something like this here to be more specific:
forNode(node).setType(m_graph, m_codeBlock->globalObjectFor(node->origin.semanitc)->withScopeStructure())

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170811/fedf1225/attachment.html>