[Webkit-unassigned] [Bug 175475] New: [CMake] Many warning about missing “override” keywords in ANGLE with Clang

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 11 03:24:14 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=175475

            Bug ID: 175475
           Summary: [CMake] Many warning about missing “override” keywords
                    in ANGLE with Clang
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: lforschler at apple.com

Currently building ANGLE as part of WebCore with Clang spews a good bunch
of warnings similar to the following one:

  In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.cpp:10:
  In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.h:13:
  ../../Source/ThirdParty/ANGLE/src/compiler/translator/OutputHLSL.h:86:10: warning: 'visitBranch' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      bool visitBranch(Visit visit, TIntermBranch *);
           ^
  ../../Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.h:957:18: note: overridden virtual function is here
      virtual bool visitBranch(Visit visit, TIntermBranch *node) { return true; }
                   ^

As ANGLE is third-party code, let's to pass “-Wno-inconsistent-missing-override”
when building its sources.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170811/3b6153f3/attachment-0001.html>


More information about the webkit-unassigned mailing list