[Webkit-unassigned] [Bug 174798] Web Inspector: Add three.js in preparation for layer visualization.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 10 12:10:24 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174798

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bburg at apple.com

--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 316332
  --> https://bugs.webkit.org/attachment.cgi?id=316332
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316332&action=review

Please upload a new patch with directory rename.

When you actually hook this into the build system, you'll need to make sure it gets minified properly. That should be in a follow up patch separate from the source dump.

> Source/WebInspectorUI/ChangeLog:8
> +        * UserInterface/External/Three/LICENSE: Added.

Can you put it into directory named three.js or threejs instead of Three?

> Source/WebInspectorUI/UserInterface/Main.html:246
> +    <script src="External/Three/OrbitControls.js"></script>

No need to include it until it's used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170810/177f9fb6/attachment.html>


More information about the webkit-unassigned mailing list