[Webkit-unassigned] [Bug 175427] [CMake] Fix broken use of REQUIRED with find modules
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 10 11:02:15 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=175427
--- Comment #5 from Konstantin Tokarev <annulen at yandex.ru> ---
(In reply to Konstantin Tokarev from comment #4)
> (In reply to Michael Catanzaro from comment #2)
> > I have no strong preference. Do want to write the patch, or shall I?
> >
> > Are we going to have to change WEBP_LIBRARIES and WEBP_INCLUDE_DIRS to
> > WebP_LIBRARIES and WebP_FOUND as well?
>
> If we go to WebP way, yes
Oops, actually no. It's just a good practise but not a requirement, and old modules like FindLibXml2 do this. What matters is that X in FindX.cmake and in find_package_handle_standard_args(X ...) have the same case.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170810/0a4a4124/attachment.html>
More information about the webkit-unassigned
mailing list