[Webkit-unassigned] [Bug 175427] New: Fix broken use of REQUIRED with find modules

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175427

            Bug ID: 175427
           Summary: Fix broken use of REQUIRED with find modules
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org

>From bug #175426:

FindWebP failed to find libwebp on my test system and printed an error, but I guess it must have set WEBP_FOUND=1 or something because the build proceeded even though it was REQUIRED.

Konstantin discovered that REQUIRED was not working properly:

> No, by design it should result in fatal error. However, I've found why it
> doesn't happen for WebP and GeoClue: package names are case-sensitive, so
> WebP != WEBP, and WEBP_FOUND being false is ignored because cmake looks for
> WebP_FOUND. We either need to rename FindWebP.cmake to FindWEBP.cmake and
> use find_package(WEBP), or use "WebP" spelling consistently. Same for other
> packages with mixed case names.

So we need to call in the case-sensitivity police to fix OptionsGTK.cmake (and probably other ports, too).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170810/f3c4040f/attachment.html>