[Webkit-unassigned] [Bug 175175] [PAL] Move spi/cocoa and spi/cg directories into PAL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 9 17:15:41 PDT 2017


Myles C. Maxfield <mmaxfield at apple.com> changed:

           What    |Removed                     |Added
 Attachment #317640|review?                     |review+
              Flags|                            |

--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 317640
  --> https://bugs.webkit.org/attachment.cgi?id=317640

View in context: https://bugs.webkit.org/attachment.cgi?id=317640&action=review

I'm not an OWNER of the WebKit subproject, but just the change in pathnames shouldn't require an OWNER. Other than the style for the "*" character, this looks good.

> Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.hSource/WebCore/platform/spi/cocoa/AVKitSPI.h:74
> + at property (nonatomic, readonly) AVPictureInPicturePlayerLayerView* pictureInPicturePlayerLayerView;

Unfortunately, this is actually backwards. The style is:

For C and C++ types:
Type* foo;

For Objective-C types:
Type *foo;

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170810/cf4dfd44/attachment-0001.html>

More information about the webkit-unassigned mailing list