[Webkit-unassigned] [Bug 174710] WebDriver: handle click events on option elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174710

--- Comment #10 from Brian Burg <bburg at apple.com> ---
Comment on attachment 317573
  --> https://bugs.webkit.org/attachment.cgi?id=317573
Try to fix mac builds

View in context: https://bugs.webkit.org/attachment.cgi?id=317573&action=review

>>> Source/WebKit/UIProcess/Automation/Automation.json:435
>>> +            "name": "selectOptionElement",
>> 
>> This seems fine, but maybe call it toggleOptionElement?
> 
> It only toggles when the select is multiple, otherwise it selects the element (in case of combo element).

Okay, let's leave it as is.

>>> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:632
>>> +    selectElement->optionSelectedByUser(optionElement.index(), true, selectElement->multiple());
>> 
>> This won't fire mouseover/move/down/up/click events like the spec wants. We'll probably have to simulate those events ourselves as the only way to do it natively would be to try and click the native widgets. I think that would be problematic for dropdown menus as the interaction is a bit more subtle than the DOM events would lead you to believe.
> 
> I know, even when it's in the spec I don't think selenium will expect we fire all those events, at least we fire the important ones also mentioned in the spec, the input and change events. I'll add a FIXME about the other events, but I wouldn't block this feature on those.

Agree, it seems kinda pointless and hopefully people don't depend on these events.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170809/959d4ba8/attachment.html>