[Webkit-unassigned] [Bug 175315] WebDriver: timeout when JavaScript alert is shown in onload handler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 8 23:55:26 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=175315

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 317553
  --> https://bugs.webkit.org/attachment.cgi?id=317553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317553&action=review

>> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:412
>> +    bool shouldFailWithUnexpectedAlertOpen = page->pageLoadState().isLoading() && m_client->isShowingJavaScriptDialogOnPage(*this, *page);
> 
> Should this depend on the page load strategy? If we only care about DOMContentLoaded then this seems incorrect.

Good point!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170809/e79a0b11/attachment.html>


More information about the webkit-unassigned mailing list