[Webkit-unassigned] [Bug 175358] JSTests/stress/v8-deltablue-strict.js fails with JSC_validateExceptionChecks=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175358

--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 317650
  --> https://bugs.webkit.org/attachment.cgi?id=317650
Simple bookkeeping fix in two places

View in context: https://bugs.webkit.org/attachment.cgi?id=317650&action=review

>>> Source/JavaScriptCore/jit/JITOperations.cpp:1064
>>> +        ASSERT(throwScope.exception() || !error);
>> 
>> Out of curiosity, why is the throwException below needed if we're just rethrowing the exception? Or is that not what's happening?
> 
> There's a better way to express this assertion.  See the other examples of calls to functionExecutable->prepareForExecution() in this file above.

And yes, it looks like the throwException below is actually not needed though it is harmless.  You can remove it here (as well as at the other exception checks after calls to functionExecutable->prepareForExecution() above in this file.  Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170809/d64fc7ba/attachment.html>