[Webkit-unassigned] [Bug 175347] JSTests/slowMicrobenchmarks/spread-small-array.js fails with JSC_validateExceptionChecks=1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 8 15:32:30 PDT 2017


Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
 Attachment #317631|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 317631
  --> https://bugs.webkit.org/attachment.cgi?id=317631
Same patch, with the whitespace issues fixed

View in context: https://bugs.webkit.org/attachment.cgi?id=317631&action=review

r=me with changelog fix

> Source/JavaScriptCore/ChangeLog:10
> +        This is done by making finishCreation explicitely check for exceptions after setConstantRegister and setConstantIdentifiersSetRegisters.
> +        I chose to have this check replace the boolean returned previously by these functions for readability. The performance impact should be
> +        negligible considering how much more finishCreation does.
> +        This fix then caused another issue to appear as it was now clear that finishCreation can throw. And since it is called by ProgramCodeBlock::create(),
> +        FunctionCodeBlock::create() and friends, that are in turn called by ScriptExecutable::newCodeBlockFor, this last function also required a few tweaks.

Style nit: This explanation should go below the "Reviewed by ..."

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170808/9fd8d69b/attachment.html>

More information about the webkit-unassigned mailing list