[Webkit-unassigned] [Bug 175322] New: [WPE] Implement WebsiteDataStore::defaultApplicationCacheDirectory() and friends

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 8 07:22:22 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=175322

            Bug ID: 175322
           Summary: [WPE] Implement
                    WebsiteDataStore::defaultApplicationCacheDirectory()
                    and friends
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit WPE
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: bugs-noreply at webkitgtk.org

These are unimplemented, “APIWebsiteDataStore.cpp” has guards

  #if !PLATFORM(COCOA) && !PLATFORM(GTK)

which means that WPE is using the empty implementations. I think the
best way to go about this is renaming the GTK+ port implementation to
“APIWebsiteDataStoreGLib.cpp” file. That would be used both by the GTK+
and WPE ports, with a preprocessor switch inside the file to choose
the name of the base directory being used. Something in the lines of:

  #if PLATFORM(GTK)
  # define PLATFORM_DIR_BASE "webkitgtk"
  #elif PLATFORM(WPE)
  # define PLATFORM_DIR_BASE "wpe"
  #else
  # error Invalid platform
  #endif 

and then use the definition in the functions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170808/0b88781e/attachment.html>


More information about the webkit-unassigned mailing list