[Webkit-unassigned] [Bug 174477] Create Individual EWS Pages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 7 13:26:18 PDT 2017


--- Comment #11 from Dean Johnson <dean_johnson at apple.com> ---
Comment on attachment 317447
  --> https://bugs.webkit.org/attachment.cgi?id=317447
status bubble link to individual EWS page.

View in context: https://bugs.webkit.org/attachment.cgi?id=317447&action=review

> Tools/QueueStatusServer/handlers/patch.py:51
> +                queue_status[status.queue_name] = per_queue_statuses

I would recommend rewriting L41-L51 as follows:

queue_status = {}
for status in statuses:
    bug_id = status.active_bug_id  # Should be the same for every status
    per_queue_statuses = queue_status.get(status.queue_name, [])
    queue_status[status.queue_name] = per_queue_statuses

# Show a single EWS status instead of all.
if queue_name is not None:  
    single_queue_status = {}
    single_queue_status[queue_name] = queue_statuses.get(status.queue_name, [])
    queue_statuses = single_queue_status

This is optimal because it allows for existing code to continue functioning as it was, and just picks out the individual status if it's requested.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170807/abc7d038/attachment.html>

More information about the webkit-unassigned mailing list